Thread (49 messages) 49 messages, 3 authors, 2018-09-27

Re: [PATCH 03/30] mm: remove CONFIG_HAVE_MEMBLOCK

From: Mike Rapoport <hidden>
Date: 2018-09-26 18:32:20
Also in: linux-alpha, linux-mips, linux-mm, linux-riscv, linux-sh, linux-um, linuxppc-dev, lkml, sparclinux

On Wed, Sep 26, 2018 at 09:58:41AM -0700, Alexander Duyck wrote:
On Fri, Sep 14, 2018 at 5:11 AM Mike Rapoport [off-list ref] wrote:
quoted
All architecures use memblock for early memory management. There is no need
for the CONFIG_HAVE_MEMBLOCK configuration option.

Signed-off-by: Mike Rapoport <redacted>
<snip>
quoted
diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 5169205..4ae91fc 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -2,7 +2,6 @@
 #define _LINUX_MEMBLOCK_H
 #ifdef __KERNEL__

-#ifdef CONFIG_HAVE_MEMBLOCK
 /*
  * Logical memory blocks.
  *
@@ -460,7 +459,6 @@ static inline phys_addr_t memblock_alloc(phys_addr_t size, phys_addr_t align)
 {
        return 0;
 }
-#endif /* CONFIG_HAVE_MEMBLOCK */

 #endif /* __KERNEL__ */
There was an #else above this section and I believe it and the code
after it needs to be stripped as well.
Right, I've already sent the fix [1] and it's in mmots.

[1] https://lkml.org/lkml/2018/9/19/416

-- 
Sincerely yours,
Mike.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help