Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The patch removes the MFD_IPAQ_MICRO core driver, but leaves behind references to its non-existent Kconfig symbol in select statements, as well as orphaned child drivers and header files.
- [Low] The commit message does not follow the mandatory prefix and capitalization rules for the MFD subsystem.
--
commit 083382aa696919c18a4b69206eaec876c285e518
Author: Arnd Bergmann [off-list ref]
mfd: remove unused iPaq micro driver
The iPaq support has been removed from the kernel, this driver is
no longer used anywhere.
mfd: remove unused iPaq micro driver
[Severity: Low]
Is the commit message subject missing the standard MFD prefix format?
It appears the format should be "mfd: <Driver>: <Capitalized description>"
rather than "mfd: remove unused iPaq micro driver".
quoted hunk ↗ jump to hunk
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 02e52398fcd28..6189bd7cc1098 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -780,16 +780,6 @@ config MFD_INTEL_PMC_BXT
Register and P-unit access. In addition this creates devices
for iTCO watchdog and telemetry that are part of the PMC.
-config MFD_IPAQ_MICRO
- bool "Atmel Micro ASIC (iPAQ h3100/h3600/h3700) Support"
[Severity: High]
Are there still orphaned references to this config symbol in other parts of
the tree?
For example, arch/arm/mach-sa1100/Kconfig still selects this symbol for
SA1100_H3600:
select MFD_IPAQ_MICRO
This causes unmet dependency warnings during the build.
Additionally, child drivers like KEYBOARD_IPAQ_MICRO in
drivers/input/keyboard/Kconfig still depend on it:
depends on MFD_IPAQ_MICRO
which turns them into unselectable dead code.
Should the child driver source files and headers be removed as well?
In drivers/leds/leds-ipaq-micro.c, micro_leds_brightness_set() attempts to
call a function from the MFD core that has just been removed:
return ipaq_micro_tx_msg_sync(micro, &msg);
The header include/linux/mfd/ipaq-micro.h also remains, declaring APIs like
ipaq_micro_tx_msg() that no longer have an implementation.
- depends on SA1100_H3600
- select MFD_CORE
- help
- Select this to get support for the Microcontroller found in
- the Compaq iPAQ handheld computers. This is an Atmel
- AT90LS8535 microcontroller flashed with a special iPAQ
- firmware using the custom protocol implemented in this driver.
-
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909132153.1596191-1-arnd@kernel.org?part=14