Re: [PATCH v6 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers

From
Wolfram Sang <wsa+renesas@sang-engineering.com>
Date
2026-08-22 19:22:32
Also in
linux-devicetree, sashiko-reviews
Reply to
sashiko-bot@kernel.org, 2026-08-21
On Fri, Aug 21, 2026 at 09:26:11PM +0000, sashiko-bot@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:

Pre-existing issues:
- [High] Data race and TOCTOU in IRQ handler leading to spurious interrupts and incomplete synchronization
- [High] Hardware state lockup on timeout in rzn1_rtc_set_time()
- [High] Alarm logic erroneously uses 1-second interrupt for past alarms with the same minute
- [Medium] Race window in rzn1_rtc_read_time() fallback logic can produce inconsistent timestamps
All pre-existing issues, should be handled incrementally.

Attachments

Thread (38 messages) 38 messages, 4 authors, last reply 2026-08-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help