On 16/08/2022 15:54, zhiyong.tao wrote:

On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote:

quoted

On Fri, 12 Aug 2022 at 15:52, zhiyong.tao [off-list ref]
wrote:

quoted

On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote:

quoted

On 12/08/2022 12:29, Zhiyong Tao wrote:

quoted

Add mt6366 regulator document

+
+properties:
+  compatible:
+    const: mediatek,mt6366-regulator
+
+  regulators:
+    type: object
+    description: List of regulators and its properties
+
+    patternProperties:
+      "^buck-
v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$":
+        type: object
+        $ref: regulator.yaml#
+        unevaluatedProperties: false
+
+      "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$":
+        type: object
+        $ref: regulator.yaml#

You miss unevaluatedProperties in most of the places.

Hi Krzysztof,
   Thanks for your suggestion,
   Do you mean that all places should have the
unevaluatedProperties
Properties ?

Yes. You put it in some of the places which does not really make
sense...

Hi Krzysztof,
   Thanks for your suggestion,
   We find that if there is a properties "compatible = "regulator-
fixed";" in ldo-vrf12, we should set unevaluatedProperties as true.
or it will check yaml warning "Unevaluated Properties are not
allowed('compatible' was unexpected)". is it right?
   There is a properties "compatible = "regulator-fixed";"in ldo-vrf12.
It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a
required property". Can you help to give a suggestion to fix the
warning? Add regulator-name for ldo-vrf12 or other suggestion?

And how this regulator is supposed to work? Are you populating DT
children in your driver?

Best regards,
Krzysztof