Re: [PATCH v2 12/14] dt-bindings: ata: Convert Broadcom SATA to YAML
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-12-07 18:29:27
Also in:
linux-arm-kernel, linux-crypto, linux-devicetree, linux-gpio, linux-ide, linux-mmc, linux-pm, linux-pwm, linux-usb, lkml
On 12/7/21 6:58 AM, Rob Herring wrote:
On Mon, 06 Dec 2021 10:26:14 -0800, Florian Fainelli wrote:quoted
Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML to help with validation. Acked-by: Damien Le Moal <redacted> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- .../bindings/ata/brcm,sata-brcm.txt | 45 --------- .../bindings/ata/brcm,sata-brcm.yaml | 91 +++++++++++++++++++ 2 files changed, 91 insertions(+), 45 deletions(-) delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yamlRunning 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1564108 ahci@41000: $nodename:0: 'ahci@41000' does not match '^sata(@.*)?$' arch/arm/boot/dts/bcm958522er.dt.yaml arch/arm/boot/dts/bcm958525er.dt.yaml arch/arm/boot/dts/bcm958525xmc.dt.yaml arch/arm/boot/dts/bcm958622hr.dt.yaml arch/arm/boot/dts/bcm958623hr.dt.yaml arch/arm/boot/dts/bcm958625hr.dt.yaml arch/arm/boot/dts/bcm958625k.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml arch/arm/boot/dts/bcm988312hr.dt.yaml ahci@41000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'dma-coherent', 'sata-port@0', 'sata-port@1' were unexpected) arch/arm/boot/dts/bcm958522er.dt.yaml arch/arm/boot/dts/bcm958525er.dt.yaml arch/arm/boot/dts/bcm958525xmc.dt.yaml arch/arm/boot/dts/bcm958622hr.dt.yaml arch/arm/boot/dts/bcm958623hr.dt.yaml arch/arm/boot/dts/bcm958625hr.dt.yaml arch/arm/boot/dts/bcm958625k.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml arch/arm/boot/dts/bcm988312hr.dt.yaml ahci@41000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'sata-port@0', 'sata-port@1' were unexpected) arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml sata@a000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm/boot/dts/bcm963138dvt.dt.yaml
All of those fixed in v3. -- Florian