Re: [PATCH v4 8/9] watchdog: max77620: add comment to clarify set_timeout procedure
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-11-29 19:42:45
Also in:
linux-devicetree, linux-watchdog, lkml
On Sat, Nov 20, 2021 at 04:57:06PM +0100, Luca Ceresoli wrote:
Clarify why we need to ping the watchdog before changing the timeout by quoting the MAX77714 datasheet.
Unless I am missing something, this adds confusion instead of clarifying anything, and it is misleading. The added comment in the code makes it sound like clearing the watchdog timer is only needed for MAX77614. However, the code was in place for MAX77620, suggesting that it was needed for that chip as well and is not MAX77614 specific. Please either drop this patch or rephrase it to clarify that it applies to both chips. Guenter
quoted hunk ↗ jump to hunk
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- This patch is new in v4. It adds a clarification comment to the max77620 driver taken from v3 patch 7. --- drivers/watchdog/max77620_wdt.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/drivers/watchdog/max77620_wdt.c b/drivers/watchdog/max77620_wdt.c index 06b48295fab6..f082a4ea2c03 100644 --- a/drivers/watchdog/max77620_wdt.c +++ b/drivers/watchdog/max77620_wdt.c@@ -132,6 +132,11 @@ static int max77620_wdt_set_timeout(struct watchdog_device *wdt_dev, break; } + /* + * "If the value of TWD needs to be changed, clear the system + * watchdog timer first [...], then change the value of TWD." + * (MAX77714 datasheet) + */ ret = regmap_update_bits(wdt->rmap, wdt->drv_data->reg_cnfg_glbl3, wdt->drv_data->wdtc_mask, 0x1); if (ret < 0)