Thread (10 messages) 10 messages, 3 authors, 2021-11-09

Re: [PATCH 1/2] rtc-rv8803: fix writing back ctrl in flag register

From: Dominique Martinet <hidden>
Date: 2021-11-08 23:41:59
Also in: lkml

Alexandre Belloni wrote on Mon, Nov 08, 2021 at 09:42:53AM +0100:
On 08/11/2021 12:16:59+0900, Dominique Martinet wrote:
quoted
Hi Alexandre, Alessandro,

the other patch was proved to be unneeded, but this one is still a valid
fix as far as I can understand the code (reusing RV8803_CTRL value to
write into RV8803_FLAG does not look correct)

(I'm also convinced either mostly work because the original values are
usually close enough, but that's not a reason to keep using the wrong
one)


Would you have time to take a look?
I did check with the initial review and I'm going to apply it, I just
didn't have the time to do that yet.
Sorry, it wasn't clear to me whether this was dropped with the other or
not.

There's no hurry on my end, please apply when you can!


Thanks,
-- 
Dominique
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help