Thread (12 messages) 12 messages, 5 authors, 2021-10-23

Re: [PATCH v1 3/3] mfd: tps80031: Remove driver

From: Lee Jones <hidden>
Date: 2021-10-22 09:54:56
Also in: linux-i2c, lkml

On Fri, 22 Oct 2021, Dmitry Osipenko wrote:
22.10.2021 11:05, Lee Jones пишет:
quoted
On Thu, 21 Oct 2021, Dmitry Osipenko wrote:
quoted
Driver was upstreamed in 2013 and never got a user, remove it.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/mfd/Kconfig          |  14 -
 drivers/mfd/Makefile         |   1 -
 drivers/mfd/tps80031.c       | 526 -----------------------------
 include/linux/mfd/tps80031.h | 637 -----------------------------------
 4 files changed, 1178 deletions(-)
 delete mode 100644 drivers/mfd/tps80031.c
 delete mode 100644 include/linux/mfd/tps80031.h
quoted
-static const struct i2c_device_id tps80031_id_table[] = {
-	{ "tps80031", TPS80031 },
-	{ "tps80032", TPS80032 },
-	{ }
-};
This is an I2C driver, right?

I was under the impression that Linux could do auto-probing on I2C
devices?  Such that they do not require platform code or DT in order
to bind?
It's I2C driver. I'm not sure about auto-probing because something
should provide information about device to Linux. It's possible to
detect/scan whether there is device sitting on I2C address, but there is
no auto-discovery mechanism, AFAIK.

TPS80031 device will fail to bind to this driver because it explicitly
requires platform data which should be NULL if device is probed solely
by I2C ID.
This is a fair point.

I'll take the patch, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help