Re: [PATCH 3/4] rtc: s3c: Extract read/write IO into separate functions

On 19/10/2021 15:17, Sam Protsenko wrote:

Create dedicated functions for I/O operations and BCD conversion. It can
be useful to separete those from representation conversion and other
stuff found in RTC callbacks, e.g. for initializing RTC registers.
This patch does not introduce any functional changes, it's merely
refactoring change.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 drivers/rtc/rtc-s3c.c | 98 +++++++++++++++++++++++++++----------------
 1 file changed, 61 insertions(+), 37 deletions(-)

Looks correct:

Reviewed-by: Krzysztof Kozlowski <redacted>


Best regards,
Krzysztof