Re: [PATCH] rtc: cmos: Disable irq around direct invocation of cmos_interrupt()
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2021-03-15 21:49:54
Also in:
lkml
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2021-03-15 21:49:54
Also in:
lkml
On 05/03/2021 15:27:52+0200, Ville Syrjälä wrote:
quoted
which breaks S3-resume on fi-kbl-soraka presumably as that's slow enough to trigger the alarm during the suspend. Fixes: 6950d046eb6e ("rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ")Sigh. I wish people would at least try to check the code/history before doing these blind "cleanups" :(
Sorry I didn't catch that when applying. I'm usually more wary when getting those kind of cleanups. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com