Hi Thomas,

On Mon, Jan 11, 2021 at 11:12 AM Thomas Gleixner [off-list ref] wrote:

On Tue, Dec 29 2020 at 20:41, Geert Uytterhoeven wrote:

quoted

quoted

Reported-by: Miroslav Lichvar <redacted>
Signed-off-by: Thomas Gleixner <redacted>

Thanks for your patch, which is now commit c9e6189fb03123a7 ("ntp: Make
the RTC synchronization more reliable").

Since this commit, the I2C RTC on the R-Car M2-W Koelsch development
board is accessed every two seconds.  Sticking a WARN() in the I2C
activation path gives e.g.

Huch? Every two seconds? The timer is armed with 11 * 60 * NSEC_PER_SEC,
which is 11 minutes. Confused....

Thanks for the hint:

    #define SYNC_PERIOD_NS (11UL * 60 * NSEC_PER_SEC)

is truncated on 32-bit platforms.

Patch sent.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds