Thread (17 messages) 17 messages, 6 authors, 2018-10-23

Re: [PATCH v3 1/5] mfd: rk808: Add RK817 and RK809 support

From: Lee Jones <hidden>
Date: 2018-10-23 06:26:09
Also in: linux-arm-kernel, linux-clk, linux-devicetree, linux-rockchip, lkml

quoted
quoted
     The rk809 and rk817 are a Power Management IC (PMIC) for multimedia
     and handheld devices. It contains the following components:

         - Regulators
         - RTC
         - Clocking

     Both RK809 and RK817 chips are using a similar register map,
     so we can reuse the RTC and Clocking and regulators functionality.

Signed-off-by: Tony Xie <redacted>
---
  drivers/mfd/Kconfig       |   6 +-
  drivers/mfd/rk808.c       | 218 +++++++++++++++++++++++++++++++++++++++++++++-
  include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++
  kernel/reboot.c           |   1 +
  4 files changed, 391 insertions(+), 6 deletions(-)
[...]
quoted
quoted
diff --git a/kernel/reboot.c b/kernel/reboot.c
index e4ced88..83810d7 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -49,6 +49,7 @@
   */
  void (*pm_power_off_prepare)(void);
+EXPORT_SYMBOL_GPL(pm_power_off_prepare);
Why do you need this where no other driver in the kernel does?
    There is a gpio_slp pin for RK809 and RK817,this pin has reset、power
down and sleep functions,so
    when system is going to power down, this pin is needed to switch to
power down function,and then we just only control
    this pin to high to power down the system in atf at last。
There are other PM call-backs that you can use for this.  There
shouldn't be any requirement to export and call functions at this
level directly.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help