Thread (5 messages) 5 messages, 2 authors, 2018-08-27

Re: [PATCH] rtc: jz4740: Drop dependency on MACH_INGENIC

From: Paul Cercueil <paul@crapouillou.net>
Date: 2018-08-20 19:18:30
Also in: lkml

Hi,

Le lun. 20 ao=FBt 2018 =E0 21:12, Alexandre Belloni=20
[off-list ref] a =E9crit :
On 20/08/2018 20:07:16+0200, Paul Cercueil wrote:
quoted
 Depending on MACH_INGENIC prevent us from creating a generic kernel=20
that
 works on more than one MIPS board. Instead, we just depend on MIPS=20
being
 set.
=20
Maybe you could consider dropping the whole dependency as we already
know it will build on every architecture.
Well, I didn't really want the Kconfig option to show on the menu when
compiling for non-MIPS, since it's only ever useful there.

Should I drop the dependency then?
quoted
=20
 Signed-off-by: Paul Cercueil [off-list ref]
 ---
  drivers/rtc/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
=20
 diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
 index a2ba5db36145..98c7f19256b1 100644
 --- a/drivers/rtc/Kconfig
 +++ b/drivers/rtc/Kconfig
 @@ -1608,7 +1608,7 @@ config RTC_DRV_MPC5121
=20
  config RTC_DRV_JZ4740
  	tristate "Ingenic JZ4740 SoC"
 -	depends on MACH_INGENIC || COMPILE_TEST
 +	depends on MIPS || COMPILE_TEST
  	help
  	  If you say yes here you get support for the Ingenic JZ47xx SoCs=20
RTC
  	  controllers.
 --
 2.11.0
=20
=20
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help