Re: [PATCH v4 3/4] rtc: omap: use of_device_is_system_power_controller function
From: Johan Hovold <johan@kernel.org>
Date: 2018-07-19 10:34:30
Also in:
linux-omap, lkml
On Thu, Jul 12, 2018 at 10:37:39AM +0530, Keerthy wrote:
quoted hunk ↗ jump to hunk
Use of_device_is_system_power_controller instead of manually reading the system-power-controller property from the device tree node. Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/rtc/rtc-omap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index cb19ece..3610efd 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c@@ -753,8 +753,7 @@ static int omap_rtc_probe(struct platform_device *pdev) if (of_id) { rtc->type = of_id->data; rtc->is_pmic_controller = rtc->type->has_pmic_mode && - of_property_read_bool(pdev->dev.of_node, - "system-power-controller"); + of_device_is_system_power_controller(pdev->dev.of_node);
Nit: Continuation lines should be indented at least two tabs further, but in this case an exception seems warranted to keep the line within 80 cols.
} else {
id_entry = platform_get_device_id(pdev);
rtc->type = (void *)id_entry->driver_data;Reviewed-by: Johan Hovold <johan@kernel.org>