Thread (105 messages) 105 messages, 4 authors, 2018-02-22
STALE3030d

[PATCH 048/100] rtc: mt7622: stop validating rtc_time in .read_time

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2018-02-21 21:13:38
Also in: lkml
Subsystem: arm/mediatek rtc driver, real time clock (rtc) subsystem, the rest · Maintainers: Eddie Huang, Sean Wang, Alexandre Belloni, Linus Torvalds

The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-mt7622.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-mt7622.c b/drivers/rtc/rtc-mt7622.c
index d79b9ae4d237..da213278f343 100644
--- a/drivers/rtc/rtc-mt7622.c
+++ b/drivers/rtc/rtc-mt7622.c
@@ -232,7 +232,7 @@ static int mtk_rtc_gettime(struct device *dev, struct rtc_time *tm)
 
 	mtk_rtc_get_alarm_or_time(hw, tm, MTK_TC);
 
-	return rtc_valid_tm(tm);
+	return 0;
 }
 
 static int mtk_rtc_settime(struct device *dev, struct rtc_time *tm)
-- 
2.16.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help