[rtc-linux] Re: [PATCH v3 4/4] mfd: cros_ec: add RTC as mfd subdevice
From: Lee Jones <hidden>
Date: 2017-07-20 07:15:45
Also in:
linux-iio, lkml
On Wed, 12 Jul 2017, Enric Balletbo i Serra wrote:
quoted hunk ↗ jump to hunk
From: Stephen Barber <redacted> =20 If the EC supports RTC host commands, expose an RTC device. =20 Signed-off-by: Stephen Barber <redacted> Signed-off-by: Enric Balletbo i Serra <redacted> --- drivers/mfd/cros_ec.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) =20diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index 75a27a6..ff972fb 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c@@ -51,6 +51,10 @@ static const struct mfd_cell ec_pd_cell =3D { .pdata_size =3D sizeof(pd_p), };=20 +static const struct mfd_cell ec_rtc_cell =3D { + .name =3D "cros-ec-rtc", +}; + static irqreturn_t ec_irq_thread(int irq, void *data) { struct cros_ec_device *ec_dev =3D data;@@ -245,6 +249,16 @@ static void cros_ec_sensors_register(struct cros_ec_=
device *ec_dev)
kfree(msg);
}
=20
+static void cros_ec_rtc_register(struct cros_ec_device *ec_dev)
+{
+ int ret;
+
+ ret =3D mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, &ec_rtc_cell,
+ 1, NULL, 0, NULL);
+ if (ret)
+ dev_err(ec_dev->dev, "failed to add EC RTC\n");
+}Why do you need a new function just to call a single function? And by making it void, you're also loosing the return value. If mfd_add_devices() fails, something has gone wrong!
quoted hunk ↗ jump to hunk
int cros_ec_register(struct cros_ec_device *ec_dev) { struct device *dev =3D ec_dev->dev;@@ -294,6 +308,10 @@ int cros_ec_register(struct cros_ec_device *ec_dev) if (cros_ec_check_features(ec_dev, EC_FEATURE_MOTION_SENSE)) cros_ec_sensors_register(ec_dev);=20 + /* Check whether this EC has RTC support */ + if (cros_ec_check_features(ec_dev, EC_FEATURE_RTC)) + cros_ec_rtc_register(ec_dev); + if (ec_dev->max_passthru) { /* * Register a PD device as well on top of this device.
--=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.