[rtc-linux] Re: [PATCH v3 4/4] mfd: cros_ec: add RTC as mfd subdevice
From: Lee Jones <hidden>
Date: 2017-03-14 14:00:17
Also in:
lkml
On Tue, 14 Feb 2017, Enric Balletbo i Serra wrote:
quoted hunk ↗ jump to hunk
From: Stephen Barber <redacted> =20 If the EC supports RTC host commands, expose an RTC device. =20 Signed-off-by: Stephen Barber <redacted> Signed-off-by: Enric Balletbo i Serra <redacted> Acked-by: Benson Leung <bleung@chromium.org> --- Changes since v2: - Acked by Benson Leung Changes since v1: - none =20 drivers/platform/chrome/cros_ec_dev.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) =20diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chr=
ome/cros_ec_dev.c
quoted hunk ↗ jump to hunk
index 47268ec..ebe029d 100644--- a/drivers/platform/chrome/cros_ec_dev.c +++ b/drivers/platform/chrome/cros_ec_dev.c@@ -383,6 +383,24 @@ static void cros_ec_sensors_register(struct cros_ec_=
dev *ec)
kfree(msg);
}
=20
+static const struct mfd_cell cros_ec_rtc_devs[] =3D {
+ {
+ .name =3D "cros-ec-rtc",
+ .id =3D -1,
+ },
+};
+
+static void cros_ec_rtc_register(struct cros_ec_dev *ec)
+{
+ int ret;
+
+ ret =3D mfd_add_devices(ec->dev, 0, cros_ec_rtc_devs,
+ ARRAY_SIZE(cros_ec_rtc_devs),
+ NULL, 0, NULL);
+ if (ret)
+ dev_err(ec->dev, "failed to add cros-ec-rtc device: %d\n", ret);
+}Holey poop! Why are you using the MFD API outside of MFD? Why can't you register this from the MFD driver?
quoted hunk ↗ jump to hunk
static int ec_device_probe(struct platform_device *pdev) { int retval =3D -ENOMEM;@@ -441,6 +459,10 @@ static int ec_device_probe(struct platform_device *p=
dev)
if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE)) cros_ec_sensors_register(ec); =20 + /* check whether this EC instance has RTC host command support */ + if (cros_ec_check_features(ec, EC_FEATURE_RTC)) + cros_ec_rtc_register(ec); + return 0; =20 dev_reg_failed:
--=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.