[rtc-linux] Re: [PATCH 03/14] input: utilize new device_add_cdev helper function
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-02-23 08:37:03
Also in:
linux-fsdevel, linux-gpio, linux-input, linux-rdma, linux-scsi, nvdimm
On Mon, Feb 20, 2017 at 10:00:42PM -0700, Logan Gunthorpe wrote:
Signed-off-by: Logan Gunthorpe <logang@deltatee.com> ---
Please add some more verbage, otherwise Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
quoted hunk
drivers/input/evdev.c | 3 +-- drivers/input/joydev.c | 3 +-- drivers/input/mousedev.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-)diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index e9ae3d5..a3407ea 100644 --- a/drivers/input/evdev.c +++ b/drivers/input/evdev.c@@ -1416,8 +1416,7 @@ static int evdev_connect(struct input_handler *handler, struct input_dev *dev, goto err_free_evdev; cdev_init(&evdev->cdev, &evdev_fops); - evdev->cdev.kobj.parent = &evdev->dev.kobj; - error = cdev_add(&evdev->cdev, evdev->dev.devt, 1); + error = device_add_cdev(&evdev->dev, &evdev->cdev); if (error) goto err_unregister_handle;diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c index abd18f3..012e06f 100644 --- a/drivers/input/joydev.c +++ b/drivers/input/joydev.c@@ -905,8 +905,7 @@ static int joydev_connect(struct input_handler *handler, struct input_dev *dev, goto err_free_joydev; cdev_init(&joydev->cdev, &joydev_fops); - joydev->cdev.kobj.parent = &joydev->dev.kobj; - error = cdev_add(&joydev->cdev, joydev->dev.devt, 1); + error = device_add_cdev(&joydev->dev, &joydev->cdev); if (error) goto err_unregister_handle;diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c index b604564..efd8666 100644 --- a/drivers/input/mousedev.c +++ b/drivers/input/mousedev.c@@ -901,8 +901,7 @@ static struct mousedev *mousedev_create(struct input_dev *dev, } cdev_init(&mousedev->cdev, &mousedev_fops); - mousedev->cdev.kobj.parent = &mousedev->dev.kobj; - error = cdev_add(&mousedev->cdev, mousedev->dev.devt, 1); + error = device_add_cdev(&mousedev->dev, &mousedev->cdev); if (error) goto err_unregister_handle;-- 2.1.4
-- Dmitry -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.