Hi,

On 19/12/2016 at 09:03:17 +0100, Geert Uytterhoeven wrote :

On Wed, Nov 9, 2016 at 1:37 AM, Alexandre Belloni
[off-list ref] wrote:

quoted

Since the driver is now calling machine_halt() that is not exported, it has
to be built in the kernel. Building it as a module will fail at linking
time.

Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/rtc/Kconfig      |  5 +----
 drivers/rtc/rtc-jz4740.c | 10 +---------
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 4259ce61c31b..24b0778f6e28 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig

@@ -1550,15 +1550,12 @@ config RTC_DRV_MPC5121
          will be called rtc-mpc5121.

 config RTC_DRV_JZ4740
-       tristate "Ingenic JZ4740 SoC"
+       bool "Ingenic JZ4740 SoC"

Just noticed RTC_DRV_JZ4740 flipped from m to y.

This is bad for distribution kernels.
Can't the driver just call kernel_halt() instead of machine_halt()?

I'm not sure and I can't test. Paul, can you test?

Maybe the other concern is that users that are not loading the rtc
module will probably complain their machine is not powering off.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.