[rtc-linux] Re: [PATCH v5] rtc: omap: Support ext_wakeup configuration

On 14/09/2016 at 11:21:48 +0200, Marcin Niestroj wrote :

On 13.09.2016 23:58, Alexandre Belloni wrote:

quoted

Hi,

On 12/09/2016 at 11:01:05 +0200, Marcin Niestroj wrote :

quoted

I guess we are missing PINCTRL in Kconfig. I didn't add that before,
because I thought that there is a dependency chain GENERIC_PINCONF ->
PINCONF -> PINCTRL.

So to resolve this issue:
1) Should we add "select" or "depends on" for PINCTRL?
2) Should this option be somehow related to COMPILE_TEST?

Adding a "depends on PINCTRL" line should be enough to solve that issue.

Ok, will add that together with "depends on OF", as I noticed it is
also needed.


But right now we will not be able to compile this driver with
COMPILE_TEST, unless we select some architecture that selects PINCTRL.

That is find, Arnd was pointing out that the main use case is x86
allmodconfig and that enables PINCTRL.

So maybe it is a good idea to change "config PINCTRL" option from
'bool' to 'bool "Support PINCTRL" if COMPILE_TEST', so we can enable it
manually?

This can be done too Mark Brown was suggesting it is a good idea. This
can be submitted as a separate, unrelated patch.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.