On Wednesday 31 August 2016 03:18 AM, Alexandre Belloni wrote:

Hi,

Please fix the subject, this patch is ds1347 specific.

Yes I will fix the subject

On 31/08/2016 at 01:28:33 +0530, RAGHAVENDRA GANIGA wrote :

quoted

From 2ec82b6c9b99647e31d26c4c828dc7c51af8a633 Mon Sep 17 00:00:00 2001
From: Raghavendra Ganiga <redacted>
Date: Wed, 31 Aug 2016 01:13:30 +0530
Subject: [PATCH] rtc: changed raw spi calls to register map calls

This patch changes calls of spi read write calls to register map
read and write calls

Can you explain why you need that change? I'm not sure what you gain
from it (it makes the driver and the kernel bigger).

Regmaps abstract layer are a better way of accessing register through 
spi interface rather than accessing directly through SPI layer

quoted

 	/* year in linux is from 1900 i.e in range of 100
-	in rtc it is from 00 to 99 */
+	 * in rtc it is from 00 to 99
+	 */

Unrelated change.

will have a seperate patch for this checkpatch.pl fix

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.