[rtc-linux] Re: [PATCH v7 1/4] mfd: RK808: Add RK818 support

On Fri, 19 Aug 2016, Wadim Egorov wrote:

On 18.08.2016 16:34, Lee Jones wrote:

quoted

On Wed, 10 Aug 2016, Wadim Egorov wrote:

quoted

The RK818 chip is a Power Management IC (PMIC) for multimedia and hand=

held

quoted

quoted

devices. It contains the following components:

- Regulators
- RTC
- Clocking
- Battery support

Both RK808 and RK818 chips are using a similar register map,
so we can reuse the RTC and Clocking functionality.

Signed-off-by: Wadim Egorov <redacted>
Tested-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes since v6:
- Squashed in the patch
  mfd: RK808: Fetch PMIC variant from chip id register

---
 drivers/mfd/Kconfig       |   4 +-
 drivers/mfd/rk808.c       | 226 +++++++++++++++++++++++++++++++++++++=

++-------

quoted

quoted

 include/linux/mfd/rk808.h | 154 +++++++++++++++++++++++++++++--
 3 files changed, 342 insertions(+), 42 deletions(-)

[...]

quoted

quoted

 struct rk808_reg_data {
 	int addr;

@@ -57,6 +62,14 @@ static bool rk808_is_volatile_reg(struct device *de=

v, unsigned int reg)

quoted

quoted

 	return false;
 }
=20
+static const struct regmap_config rk818_regmap_config =3D {
+	.reg_bits =3D 8,
+	.val_bits =3D 8,
+	.max_register =3D RK818_USB_CTRL_REG,
+	.cache_type =3D REGCACHE_RBTREE,
+	.volatile_reg =3D rk808_is_volatile_reg,
+};
+
 static const struct regmap_config rk808_regmap_config =3D {
 	.reg_bits =3D 8,
 	.val_bits =3D 8,

@@ -79,11 +92,21 @@ static const struct mfd_cell rk808s[] =3D {
 	{
 		.name =3D "rk808-rtc",
 		.num_resources =3D ARRAY_SIZE(rtc_resources),
-		.resources =3D &rtc_resources[0],
+		.resources =3D rtc_resources,

?

=20
you told me to change this

It's an unrelated change that has nothing to do with this patch, which
is why I am confused.

But it's okay, I'll let it sneak in on this occasion, rather than
asking you to send a separate patch.

--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.