Thread (4 messages) 4 messages, 3 authors, 2016-08-09

Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test

From: Alexandre Belloni <hidden>
Date: 2016-08-09 12:18:01
Also in: kernel-janitors, lkml

On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote :

On Tue, 9 Aug 2016, Christophe JAILLET wrote:
quoted
It is likely that checking the result of 'pcf2123_write_reg' is expected
here.
Also fix a small style issue. The '{' at the beginning of the function
is misplaced.
They shouldn't be in the same patch.  If you are wrong about the ret
issue, the { should still be moved.
That is true but as it is a really trivial patch, I didn't care that
much.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help