[rtc-linux] Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support

On 09.06.2016 13:12, Lee Jones wrote:

On Thu, 09 Jun 2016, Wadim Egorov wrote:

quoted

On 08.06.2016 16:17, Lee Jones wrote:

quoted

On Thu, 02 Jun 2016, Wadim Egorov wrote:

quoted

The RK818 chip is a power management IC for multimedia and handheld

"Power Management IC (PMIC)"

quoted

devices. It contains the following components:

- Regulators
- RTC
- Clkout

Clocking

quoted

- battery support

Battery support

quoted

Both chips RK808 and RK818 are using a similar register map.

"Both RK808 ad RK818 chips"

quoted

So we can reuse the RTC and Clkout functionality.

Swap '.' for ','.

quoted

Signed-off-by: Wadim Egorov <redacted>
---
 drivers/mfd/Kconfig       |   4 +-
 drivers/mfd/rk808.c       | 231 ++++++++++++++++++++++++++++++++++++++--------
 include/linux/mfd/rk808.h | 162 ++++++++++++++++++++++++++++++--
 3 files changed, 350 insertions(+), 47 deletions(-)

[...]

quoted

quoted

quoted

-struct rk808_reg_data {
-	int addr;
-	int mask;
-	int value;
-};

Why are you moving this to the header?

It is now part of the rk808 struct.

Why?

For me it seemed reasonable. My idea was to have only one chip variant
check.

I can move the rk808_reg_data struct back to the c file, check for the
chip variant within the probe function and initialize the proper
reg_data variable.
This would also apply to the mfd_cell variables.

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.