On 04/03/2016 at 22:54:39 +0900, Akinobu Mita wrote :

2016-03-04 8:08 GMT+09:00 Alexandre Belloni
[off-list ref]:

quoted

Hi,

I'm fine with the patches (apart from patch 7/8) but I'd like to request
one more change. Could actually support both the ds3232 and the ds3234
in the same file? That will nicely reduce the number of lines and remove
the need for an include.

For an example, you can have a look at sound/soc/codecs/wm8750.c

Sounds good.  I'll try.
Maybe we also need a trick like CONFIG_SND_SOC_I2C_AND_SPI for rtc.

Yes, feel free to add that in the Kconfig and create a new section for
RTCs that are both I2C and SPI if this is needed.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.