[rtc-linux] Re: [PATCH] rtc: pcf85063: remove useless century handling

From
Juergen Borleis <hidden>
Date
2016-03-01 08:27:20
Also in
lkml
Reply to
Alexandre Belloni, 2016-02-23
On Wednesday 24 February 2016 00:05:28 Alexandre Belloni wrote:
quoted hunk ↗ jump to hunk
pcf85063_get_datetime() tries to handle a century bit but that bit is not
documented and the final value is never used anywhere else in the kernel.

Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/rtc/rtc-pcf85063.c | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index c5db231f14de..2b3b99b094b5 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -31,13 +31,10 @@
 #define PCF85063_REG_MO			0x09
 #define PCF85063_REG_YR			0x0A

-#define PCF85063_MO_C			0x80 /* century */
-
 static struct i2c_driver pcf85063_driver;

 struct pcf85063 {
 	struct rtc_device *rtc;
-	int c_polarity;	/* 0: MO_C=3D1 means 19xx, otherwise MO_C=3D1 means 20x=
x */
quoted hunk ↗ jump to hunk
 	int voltage_low; /* indicates if a low_voltage was detected */
 };
@@ -103,9 +100,6 @@ static int pcf85063_get_datetime(struct i2c_client
*client, struct rtc_time *tm) tm->tm_year =3D bcd2bin(regs[6]);
 	if (tm->tm_year < 70)
 		tm->tm_year +=3D 100;	/* assume we are in 1970...2069 */
-	/* detect the polarity heuristically. see note above. */
-	pcf85063->c_polarity =3D (regs[5] & PCF85063_MO_C) ?
-		(tm->tm_year >=3D 100) : (tm->tm_year < 100);

 	return rtc_valid_tm(tm);
 }
Reviewed-by: Juergen Borleis <redacted>
Tested-by: Ulrich =D6lmann <redacted>

Regards,
Juergen
Thread (3 messages) 3 messages, 2 authors, last reply 2016-03-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help