[rtc-linux] Re: [PATCH 1/4] rtc-rx8025: fix irq handler registration
From: Alexandre Belloni <hidden>
Date: 2016-02-16 01:25:18
Hi, Not completely related to that patch series but I was wondering if you had access to that particular RTC. The rtc-d1307 driver claims to also support rx8025 but my guess is that is is not necessary anymore. Could you check which one we should keep? Thanks! On 15/02/2016 at 23:49:06 +0900, Akinobu Mita wrote :
quoted hunk ↗ jump to hunk
When IRQ line for this chips is connected, devm_request_threaded_irq() refuses to register irq handler with the following message. genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Wolfgang Grandegger <redacted> Cc: Alessandro Zummo <redacted> Cc: Alexandre Belloni <redacted> --- drivers/rtc/rtc-rx8025.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c index bd911ba..561248a 100644 --- a/drivers/rtc/rtc-rx8025.c +++ b/drivers/rtc/rtc-rx8025.c@@ -539,8 +539,9 @@ static int rx8025_probe(struct i2c_client *client, if (client->irq > 0) { dev_info(&client->dev, "IRQ %d supplied\n", client->irq); err = devm_request_threaded_irq(&client->dev, client->irq, NULL, - rx8025_handle_irq, 0, "rx8025", - client); + rx8025_handle_irq, + IRQF_ONESHOT, + "rx8025", client); if (err) { dev_err(&client->dev, "unable to request IRQ, alarms disabled\n"); client->irq = 0;-- 2.5.0
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.