Hello Alexandre,

On 02/15/2016 10:45 AM, Alexandre Belloni wrote:

On 15/02/2016 at 10:16:42 -0300, Javier Martinez Canillas wrote :

quoted

Commit 43f3408261a2 ("rtc: s3c: Document required clocks in the DT

I'm pretty sure you shouldn't refer to a commit that is in linux-next.

The commit comes from Rob's dt/linus branch that uses Linux 4.5-rc3 as
a base. I'm not a git expert but I thought that if the branch is not
rebased and used for the pull request then the resulting commit in
mainline would end with the same sha-1.

But I can remove the mention to the commit and "Fixes:" tag since the
commit is not yet in mainline, that should be more safe indeed.
  

quoted

binding") added to the S3C binding doc the required clocks needed
by the Real Time Clock but the S3C driver supports different HW IP
and only the s3c6410 needs a source clock.

Fix the DT binding explaning that the second clock is only needed

           explaining ^

Ok, I'll fix that typo.

quoted

by this IP block and not for the others.

Reported-by: Krzysztof Kozlowski <redacted>
Fixes: 43f3408261a2 ("rtc: s3c: Document required clocks in the DT binding")
Signed-off-by: Javier Martinez Canillas <redacted>

Anyway, I'm fine with it, feel free to add my ack.

Thanks, I'll add it in v2.
  
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.