[rtc-linux] Re: [PATCH V7 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally
From: Krzysztof Kozlowski <hidden>
Date: 2016-02-14 23:49:09
Also in:
lkml
On 10.02.2016 02:26, Laxman Dewangan wrote:
To make RTC block of MAX77686/MAX77802 as independent driver, move the registration of i2c device, regmap for register access and irq_chip for interrupt support inside the RTC driver. Removed the same initialisation from MFD driver. Having this change will allow to reuse this driver for different PMIC/devices from Maxim Semiconductor if they kept same RTC IP on different PMIC. Some of examples as PMIC MAX77620, MAX20024 where same RTC IP used and hence driver for these chips will use this driver only for RTC support. Suggested-by: Krzysztof Kozlowski <redacted> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <redacted> CC: Javier Martinez Canillas <redacted> Tested-by: Javier Martinez Canillas <redacted> Reviewed-by: Javier Martinez Canillas <redacted> --- Changes from V1: - Remove changes from Kconfig. - Maintain all register definition in max77686 private header and remove the movement to rtc driver. - Taken care of all comments on V1 from Krzysztof and Javier. Changes from V2: - Taken care of missed sequence for removing the resource. - Fix the crash when doing unbind by using requested_threaded_irq() instead of demv_requested_threaded_irq(). Changes from V3: - Fix the issue of suspend-resume with unbind/bind by unmapping the virq. Changes from V4: - Dispose mapped irq in error path in probe Changes from V5: - Remove the new APIs from regmap as functionality added to dispose the virq inside the regmap_del_irq_chip(). Changes from V6: Make this as 5th of series as regmap change applied independently. Also rebase on linux-next 20160209 drivers/mfd/max77686.c | 85 +------------------- drivers/rtc/rtc-max77686.c | 148 ++++++++++++++++++++++++++++++----- include/linux/mfd/max77686-private.h | 3 - 3 files changed, 130 insertions(+), 106 deletions(-)
Reviewed-by: Krzysztof Kozlowski <redacted> On max77686: Tested-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.