Thread (18 messages) 18 messages, 3 authors, 2016-02-09

[rtc-linux] Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally

From: Laxman Dewangan <ldewangan@nvidia.com>
Date: 2016-02-08 10:31:41
Also in: lkml

On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
-	ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
-					max77686_rtc_alarm_irq, 0,
-					"rtc-alarm1", info);
-	if (ret < 0)
+	ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
+				   "rtc-alarm1", info);
+	if (ret < 0) {
  		dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
  			info->virq, ret);
+		goto err_rtc;
+	}
+
+	return 0;
  
  err_rtc:
Oops.. I wish I should have called regmap_irq_put_virq(info->virq); here.

Please let me know if I can respin this patch only instead of entire series.


-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help