[rtc-linux] Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client
From: Krzysztof Kozlowski <hidden>
Date: 2016-02-03 10:28:02
Also in:
lkml
From: Krzysztof Kozlowski <hidden>
Date: 2016-02-03 10:28:02
Also in:
lkml
On 03.02.2016 18:30, Laxman Dewangan wrote:
There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no need to get any data from this rtc i2c client, it is not required to set client data for this i2c client. Suggested-by: Krzysztof Kozlowski <redacted> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <redacted> CC: Javier Martinez Canillas <redacted> --- This is new in this series based on review comment from V1.
You could trim a little bit the description - "stored pointer is not retrieved anywhere, there is no call to i2c_get_clientdata()" might be sufficient but anyway: Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.