On Fri, 29 Jan 2016, Rob Herring wrote:

On Wed, Jan 27, 2016 at 07:40:07PM +0530, Laxman Dewangan wrote:

quoted

MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
pins. It also supports interrupts from these pins.
=20
Add GPIO driver for these pins to control via GPIO APIs.
=20
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Chaitanya Bandi <redacted>
---
Changes from V1:
- Use the gpiochip_add_data and get the chip data from core APIs.
- Cleanups based on comment received on mfd/rtc.
- Avoid duplication on error message.
=20
Changes form V2:
- Run coccicheck and checkpatch in strict mode for the alignment.
- update based on api changes from core.
=20
Changes from V3:=20
- Change all sys initcall to module driver.
- change the max77620_read argument to unisgned int from u8.
=20
Changes from V4:=20
- Added DT binding document as devicetree/bindings/gpio/gpio-max77620.t=

xt

quoted

=20
 .../devicetree/bindings/gpio/gpio-max77620.txt     |  25 ++
 drivers/gpio/Kconfig                               |   9 +
 drivers/gpio/Makefile                              |   1 +
 drivers/gpio/gpio-max77620.c                       | 292 +++++++++++++=

++++++++

quoted

 4 files changed, 327 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-max7762=

0.txt

quoted

 create mode 100644 drivers/gpio/gpio-max77620.c
=20

diff --git a/Documentation/devicetree/bindings/gpio/gpio-max77620.txt b=

/Documentation/devicetree/bindings/gpio/gpio-max77620.txt

quoted

new file mode 100644
index 0000000..410e716

--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-max77620.txt

@@ -0,0 +1,25 @@
+GPIO driver for MAX77620 Power management IC from Maxim Semiconductor.
+
+Device has 8 GPIO pins which can be configured as GPIO as well as the
+special IO functions.
+
+Required properties:
+-------------------
+- gpio-controller : 	Marks the device node as a gpio controller.
+- #gpio-cells : 	Should be two.  The first cell is the pin number and
+			the second cell is used to specify the gpio polarity:
+				0 =3D active high
+				1 =3D active low
+For more details, please refer generic GPIO DT binding document
+<devicetree/bindings/gpio/gpio.txt>.

=20
I would just fold these 2 properties into the main max77620 document.

As these are simple/generic options, I'm happy to support that.

Also happy to support them staying in their own subsystem doc
i.e. this one, for consistency.

--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.