[rtc-linux] Re: [PATCH v3 05/10] rtc: max77686: Add an indirection level to access RTC registers
From: Krzysztof Kozlowski <hidden>
Date: 2016-01-27 01:53:16
Also in:
linux-samsung-soc, lkml
On 27.01.2016 04:20, Javier Martinez Canillas wrote:
The max77686 driver is generic enough that can be used for other Maxim RTC IP blocks but these might not have the same registers layout so instead of accessing the registers directly, add a map to translate offsets to the real registers addresses for each IP. Signed-off-by: Javier Martinez Canillas <redacted> Acked-by: Laxman Dewangan <ldewangan@nvidia.com> --- Changes in v3: - Add Laxman Dewangan's Acked-by tag to patch #5. Changes in v2: - Rename rtc_reg to max77686_rtc_reg_offset. Suggested by Krzysztof Kozlowski. - Comment what's mapped by max77686_map. Suggested by Krzysztof Kozlowski. - Use max77686_map array indexes in init. Suggested by Krzysztof Kozlowski. - Remove REG_RTC_UPDATE1 since is not used by neither max77686 nor max77802. drivers/rtc/rtc-max77686.c | 90 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 80 insertions(+), 10 deletions(-)
Thanks for changes, looks good now. Tested on Trats2 (max77686): Tested-by: Krzysztof Kozlowski <redacted> Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.