[rtc-linux] Re: [PATCH v2 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value
From: Krzysztof Kozlowski <hidden>
Date: 2016-01-22 00:51:48
Also in:
linux-samsung-soc, lkml
On 22.01.2016 05:23, Javier Martinez Canillas wrote:
quoted hunk ↗ jump to hunk
The function is always returning zero even in case of failures since the ret value was not propagated to the callers. Fix the error path. Reported-by: Krzysztof Kozlowski <redacted> Signed-off-by: Javier Martinez Canillas <redacted> --- Changes in v2: None drivers/rtc/rtc-max77686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7184a0eda793..6653c3d11b66 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c@@ -235,7 +235,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) out: mutex_unlock(&info->lock); - return 0; + return ret; } static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info)
Reviewed-by: Krzysztof Kozlowski <redacted> Tested on Trats2 board with max77686: Tested-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.