[rtc-linux] Re: [PATCH 2/8] rtc: max77686: Use usleep_range() instead of msleep()

Hello Krzysztof,

On 01/20/2016 09:37 PM, Krzysztof Kozlowski wrote:

On 21.01.2016 02:14, Javier Martinez Canillas wrote:

quoted

Documentation/timers/timers-howto.txt suggest to use usleep_range()
instead of msleep() for small msec (1ms - 20ms) since msleep() will
often sleep for 20ms for any value in that range.

This is fine in this case since 16ms is the _minimum_ delay required
by max77686 for an RTC update but by using usleep_range() instead of
msleep(), the driver can support other RTC IP blocks with a shorter
minium delay (i.e: in the range of usecs insted of msecs).

s/minium/minimum/
s/insted/instead/

Fixed.

quoted

Signed-off-by: Javier Martinez Canillas <redacted>
---

  drivers/rtc/rtc-max77686.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <redacted>

Thanks a lot for your review.
  

Best regards,
Krzysztof

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.