[rtc-linux] Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Date: 2015-08-27 12:20:37
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas [off-list ref]:
quoted hunk ↗ jump to hunk
These platform drivers have a platform device ID table but the module alias information is not created so module autoloading will not work. Signed-off-by: Javier Martinez Canillas <redacted> --- drivers/rtc/rtc-ab8500.c | 1 + drivers/rtc/rtc-max8997.c | 1 + drivers/rtc/rtc-s5m.c | 1 + 3 files changed, 3 insertions(+)diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 133d2e2e1a25..8537d1e3a995 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c@@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = { { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, }, { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
Completely irrelevant, but this array should have an empty terminating element.
}; +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
-- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.