[rtc-linux] [PATCH] drivers: rtc: fix ptr_ret.cocci warnings
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2015-07-31 09:31:23
Also in:
linux-arm-kernel, lkml
From: kbuild test robot <redacted> drivers/rtc/rtc-gemini.c:151:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu <redacted> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- Got a cleanup patch from Fengguang, maybe we can apply this too. rtc-gemini.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/rtc/rtc-gemini.c
+++ b/drivers/rtc/rtc-gemini.c@@ -148,10 +148,7 @@ static int gemini_rtc_probe(struct platf rtc->rtc_dev = rtc_device_register(pdev->name, dev, &gemini_rtc_ops, THIS_MODULE); - if (IS_ERR(rtc->rtc_dev)) - return PTR_ERR(rtc->rtc_dev); - - return 0; + return PTR_ERR_OR_ZERO(rtc->rtc_dev); } static int gemini_rtc_remove(struct platform_device *pdev)
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.