Thread (8 messages) 8 messages, 2 authors, 2015-10-01

Re: [rtc-linux] [PATCH] watchdog: stmp3xxx: Implement GETBOOTSTATUS

From: Alexandre Belloni <hidden>
Date: 2015-05-05 09:40:32
Also in: linux-watchdog

Hi,

On 20/04/2015 at 09:11:02 +0200, harald@ccbib.org wrote :
Hi Alexandre,

On Sun, 19 Apr 2015 17:37:43 +0200, Alexandre Belloni
[off-list ref] wrote:
quoted
On 19/04/2015 at 15:41:42 +0200, harald@ccbib.org wrote :
quoted
quoted
 - use syscon instead of passing callbacks to the watchdog driver
I will put looking into this onto my todo list, but I'm not familiar
with syscon yet and it is not obvious to me how to port the rtc driver
to syscon without breaking devicetree backwards compatibility. So I'd
like to defer this for later unless somebody gives me some guidance.
As the rtc driver is the one instantiating the watchdog driver, there is
no reason why the DT ABI would be broken. You simply have to create
the syscon in the RTC driver and then pass it to the watchdog driver,
the same way it is done with the callbacks.
Ok, this is less invasive than what I have been thinking. This makes
sense. 
 
I realized I confused syscon with regmap. So indeed, switching to syscon
will require a not nice change to the DT. But what I really meant was
creating a regmap from the rtc driver and pass it to the watchdog
driver.
quoted
I can have a look at doing it as I have some i.mx28 platforms.
If you can point me to a driver that is a good reference for your model,
then I can do this myself. Otherwise I'd prefer if you wrote the code.
I can do the testing though, if this helps.
You can have a look at the devm_regmap_init_mmio() users.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help