On Fri, 08 May 2015, Peter Griffin wrote:

On Fri, 08 May 2015, Lee Jones wrote:

quoted

quoted

quoted

quoted

quoted

=20
-- compatible 	: Must be one of: "st,stih407-lpc" "st,stih416-l=

pc"

quoted

quoted

quoted

quoted

quoted

-				  "st,stih415-lpc" "st,stid127-lpc"
+- compatible 	: Must be one of: "st,stih407-lpc"

=20
The same comment as the RTC DT patch, you are removing the compat=

ibles

quoted

quoted

quoted

quoted

documentation for the other supported platforms like stih416-lpc.
AFAIK they are required in the driver to get the correct sysconfi=

g register.

quoted

quoted

quoted

=20
That's intentional.  I haven't yet tested any of this IP on
STiH41{5,6} & STiH127.  Due to lack of documentation, I'm not even
sure if this IP even exists on some of the other platforms.  I will
add them back when support is added to both driver and DTB and I've
been able to test them.

=20
That was kind of my point, the driver code AFAIK already contains sup=

port

quoted

quoted

for these SoC's.
=20
I would either expect the patch to remove support from the DT docs AN=

D the

quoted

quoted

driver, or leave it as is.
=20
It seems odd to only change the DT docs, and become unaligned to the
code (this assumes I'm looking at the latest patchset here=20
https://lkml.org/lkml/2015/3/4/1088 which includes support for these =

SoCs).

quoted

=20
The decision to remove these 'supported' platforms was made on the RTC
side, where there is only support for "st,stih407-lpc" in the driver.

=20
The change makes sense in the RTC case then.
=20

quoted

I thought it best to mirror that thought over to the Watchdog LPC
bindings,

=20
Why? This is the bit I disagree with, the wdt DT docs IMHO should match t=

he wdt

driver code.

Fair enough.  I'll add the 'supported' compatibles back in.

--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.