[rtc-linux] Re: [PATCH 1/2] rtc: interface: Fix coding style violations
From: Alexandre Belloni <hidden>
Date: 2015-05-03 09:40:09
Also in:
lkml
Hi, On 23/04/2015 at 21:25:39 +0900, Krzysztof Kozlowski wrote :
quoted hunk ↗ jump to hunk
Fix issues reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: "foo* bar" should be "foo *bar" Signed-off-by: Krzysztof Kozlowski <redacted> --- include/linux/rtc.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)diff --git a/include/linux/rtc.h b/include/linux/rtc.h index c8b68741994e..85b48b29a143 100644 --- a/include/linux/rtc.h +++ b/include/linux/rtc.h@@ -101,8 +101,7 @@ struct rtc_timer { /* flags */ #define RTC_DEV_BUSY 0 -struct rtc_device -{ +struct rtc_device { struct device dev; struct module *owner;@@ -202,10 +201,10 @@ int rtc_register(rtc_task_t *task); int rtc_unregister(rtc_task_t *task); int rtc_control(rtc_task_t *t, unsigned int cmd, unsigned long arg); -void rtc_timer_init(struct rtc_timer *timer, void (*f)(void* p), void* data); -int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer* timer, +void rtc_timer_init(struct rtc_timer *timer, void (*f)(void *p), void *data); +int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer *timer, ktime_t expires, ktime_t period);
While at it, alignment here should match the open parenthesis. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.