Re: [PATCH] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
From: Rafael J. Wysocki <hidden>
Date: 2015-03-18 00:56:19
Also in:
kernel-janitors, linux-arm-kernel, lkml
On Tuesday, March 17, 2015 04:38:10 PM Nicolas Ferre wrote:
From: Dan Carpenter <redacted>
There is a typo here so we deadlock.
Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by: Dan Carpenter <redacted>
Acked-by: Boris Brezillon <redacted>
Reported-also-by: David Dueck [off-list ref]
Signed-off-by: Nicolas Ferre <redacted>
---
Hi Andrew,
Can you please take care of this fix for 4.0?
If you fee that I'd better take it myself please tell me.The commit being fixed went in through my tree, so I'll take this one if that's not a problem.
quoted hunk ↗ jump to hunk
drivers/rtc/rtc-at91rm9200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index b4f7744f6751..b283a1a573b3 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id) ret = IRQ_HANDLED; } - spin_lock(&suspended_lock); + spin_unlock(&suspended_lock); return ret; }
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.