Thread (3 messages) flat view 3 messages, 2 authors, 2d ago
WARM2d REVIEWED: 1 (1M)

1 review trailer.

[PATCH v2] cyclictest: Fix BUILD failure for GCC_VER < 14

From: Suneeth D <hidden>
Date: 2026-09-02 09:58:24
Subsystem: the rest · Maintainer: Linus Torvalds

timerthread() uses bool, true, and false. Those are keywords in C23,
which became GCC's default in GCC 15 (-std=gnu23), so the file compiles
there without stdbool.h. With the earlier versions of GCC the default is gnu17,
where they are provided by <stdbool.h>, and the build fails without it.

Fixes: 98fcd661ac59 (cyclictest: Acquire a lock before invoking pthread_cond_signal())
Closes: https://lore.kernel.org/linux-rt-users/4ce24139-5f7e-4180-a290-bcc15fb4f559@amd.com/ (local)
Signed-off-by: Suneeth D <redacted>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---

Changes since v1 ---> v2:

 * Modify commit message to include Tomas Glozar's note on default
   changes happened since GCC 15.

based on: fd45df830803dd7f26d2ca8bdcf05fd7e0d62ae8 (rt-tests/main)

 src/cyclictest/cyclictest.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 99194378f946..58b56bcede0f 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -15,6 +15,7 @@
 #include <stdlib.h>
 #include <stdint.h>
 #include <stdarg.h>
+#include <stdbool.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <getopt.h>
-- 
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help