Re: [PATCH V8 03/14] rtla: Add osnoise tool

From
Steven Rostedt <rostedt@goodmis.org>
Date
2021-12-08 22:14:13
Also in
lkml
Reply to
Daniel Bristot de Oliveira, 2021-12-02
On Thu, 2 Dec 2021 16:18:53 +0100
Daniel Bristot de Oliveira [off-list ref] wrote:
quoted
quoted
+	if (!strcmp(context->orig_cpus, context->curr_cpus))
+		goto out_done;
+
+	retval = write(context->cpus_fd, context->orig_cpus, strlen(context->orig_cpus));  
'strlen(context->orig_cpus) + 1' for write size;
  
quoted
+	if (retval < strlen(context->orig_cpus))  
Same here. Check 'strlen(context->orig_cpus) + 1'  
Fixed in v9.
And if you used the tracefs_instance_file_write() function, you would not
have had his bug ;-)

-- Steve
Thread (29 messages) 29 messages, 3 authors, last reply 2021-12-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help