[PATCH RT 1/2] locking/rwsem-rt: Remove might_sleep() in __up_read()

From
Steven Rostedt <rostedt@goodmis.org>
Date
2021-08-20 23:47:41
Also in
lkml
Reply to
Steven Rostedt, 2021-08-20
5.10.59-rt52-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Andrew Halaney <redacted>

There's no chance of sleeping here, the reader is giving up the
lock and possibly waking up the writer who is waiting on it.

Reported-by: Chunyu Hu <redacted>
Signed-off-by: Andrew Halaney <redacted>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 kernel/locking/rwsem-rt.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/kernel/locking/rwsem-rt.c b/kernel/locking/rwsem-rt.c
index 274172d5bb3a..b61edc4dcb73 100644
--- a/kernel/locking/rwsem-rt.c
+++ b/kernel/locking/rwsem-rt.c
@@ -198,7 +198,6 @@ void __up_read(struct rw_semaphore *sem)
 	if (!atomic_dec_and_test(&sem->readers))
 		return;
 
-	might_sleep();
 	raw_spin_lock_irq(&m->wait_lock);
 	/*
 	 * Wake the writer, i.e. the rtmutex owner. It might release the
-- 
2.30.2
Thread (3 messages) 3 messages, 1 author, last reply 2021-08-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help