Re: [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen
From: Atsushi Nemoto <hidden>
Date: 2021-07-29 00:23:33
From: Atsushi Nemoto <hidden>
Date: 2021-07-29 00:23:33
On Wed, 28 Jul 2021 17:38:05 -0400 (EDT), John Kacur [off-list ref] wrote:
quoted
- self.process = subprocess.Popen(self.args, + self.process = subprocess.Popen(" ".join(self.args), shell=True, stdout=self.__out, stderr=self.__err, stdin=self.__in) -- 2.11.0I don't see the need to do this here and in fact there are some security implications to using shell=True. Is there a reason you want to do this?
I want to pass multiple options using --stressng-arg. And also, there are elements with spaces in self.args already: "--timeout %s" and "--taskset %s". --- Atsushi Nemoto