Thread (7 messages) 7 messages, 3 authors, 2021-06-30

Re: [PATCH rt-tests v1 1/2] rt-utils: Call get_timestmap() in rt_init()

From: John Kacur <jkacur@redhat.com>
Date: 2021-06-30 03:05:42


On Tue, 29 Jun 2021, Kurt Kanzenbach wrote:
Hi Daniel,

On Mon Jun 28 2021, Daniel Wagner wrote:
quoted
Move the get_timestamp() from rt_test_start() to rt_init(). The idea
of rt_test_start() was to get the start timestamp right before the
'main loop' for the test starts. At least for cyclictest the
rt_test_start() was placed wrongly so that the first test cycle could
hit the pagefault when strftime() wrote into the tsbuf.

We don't have an exact semantic description what start test timestamp
means, so the simplest thing to avoid any further problems with it, is
to take the timestamp right at the beginning when the program
starts. Most test programs have a very short setup phase anyway.

Reported-by: Mike Galbraith <redacted>
Signed-off-by: Daniel Wagner <redacted>
This fixes the issue for me:

Tested-by: Kurt Kanzenbach <kurt@linutronix.de>

Thanks,
Kurt
thanks, added
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help