Re: [PATCH RT 2/6] tcp: Remove superfluous BH-disable around listening_hash

From
Steven Rostedt <rostedt@goodmis.org>
Date
2020-11-09 17:01:12
Also in
lkml
Reply to
Sebastian Andrzej Siewior, 2020-11-09
On Mon, 9 Nov 2020 10:22:31 +0100
Sebastian Andrzej Siewior [off-list ref] wrote:
On 2020-11-06 21:06:38 [-0500], Steven Rostedt wrote:
quoted
5.4.74-rt42-rc1 stable review patch.
If anyone has any objections, please let me know.  
Please drop that one. Lockep complains on RT with newer softirq code.
Older RT and mainline does not complain here unless it observes
inet_listen_hashbucket::lock in serving-softirq context (which is not
the case).
Note, I took this because it mentioned:

"Commit
       9652dc2eb9e40 ("tcp: relax listening_hash operations")
    
    removed the need to disable bottom half while acquiring
    listening_hash.lock. There are still two callers left which disable
    bottom half before the lock is acquired."

And that commit was added in 4.10.

I will remove it and release a rc2.

Thanks!

-- Steve
Thread (11 messages) 11 messages, 2 authors, last reply 2020-11-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help