Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

From
Vladimir Oltean <olteanv@gmail.com>
Date
2020-08-12 14:34:37
Also in
lkml, netdev
Reply to
Sebastian Andrzej Siewior, 2020-08-12
On Wed, Aug 12, 2020 at 03:51:44PM +0200, Sebastian Andrzej Siewior wrote:
On 2020-08-03 18:21:45 [-0700], David Miller wrote:
quoted
From: Vladimir Oltean <olteanv@gmail.com>
quoted
The driver calls napi_schedule_irqoff() from a context where, in RT,
hardirqs are not disabled, since the IRQ handler is force-threaded.
…
quoted
quoted
Signed-off-by: Jiafei Pan <redacted>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied.
Could these two patches be forwarded -stable, please? The changelog
describes this as a problem on PREEMPT_RT but this also happens on !RT
with the `threadirqs' commandline switch.

Sebastian
I expect the driver maintainers to have something to say about this. I
didn't test on stable kernels, and at least for dpaa2-eth, the change
would need to go pretty deep down the stable line.

Also, not really sure who is using the threadirqs option except for
testing purposes.

Thanks,
-Vladimir
Thread (8 messages) 8 messages, 3 authors, last reply 2020-08-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help