Re: [PATCH v2 2/2] selftests/ftrace: Distinguish between hist and synthetic event checks

From
Steven Rostedt <rostedt@goodmis.org>
Date
2020-05-29 14:53:24
Also in
lkml
Reply to
Masami Hiramatsu, 2020-05-29
On Fri, 29 May 2020 23:38:45 +0900
Masami Hiramatsu [off-list ref] wrote:
Hi Tom,

On Thu, 28 May 2020 14:32:38 -0500
Tom Zanussi [off-list ref] wrote:
quoted
With synthetic events now a separate config item as a result of
'tracing: Move synthetic events to a separate file', tests that use
both need to explicitly check for hist trigger support rather than
relying on hist triggers to pull in synthetic events.

Add an additional hist trigger check to all the trigger tests that now
require it, otherwise they'll fail if synthetic events but not hist
triggers are enabled.  
OK, this looks good to me. And if you don't want to repeat it,
you can also put the check function into the test.d/functions.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks Tom and Masami. I'm running tests on these now.

-- Steve
Thread (4 messages) 4 messages, 3 authors, last reply 2020-05-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help