Re: [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort()
From: Julia Cartwright <hidden>
Date: 2017-10-05 15:38:45
Also in:
linux-rdma, lkml
On Thu, Oct 05, 2017 at 05:27:30PM +0200, Thomas Gleixner wrote:
On Thu, 5 Oct 2017, Julia Cartwright wrote:quoted
On Tue, Oct 03, 2017 at 12:49:19PM -0300, Arnaldo Carvalho de Melo wrote:quoted
- preempt_disable(); + preempt_disable_nort(); this_cpu_inc(*sc->buffers_allocated);Have you tried this on RT w/ CONFIG_DEBUG_PREEMPT? I believe that the this_cpu_* operations perform a preemption check, which we'd trip.Good point. Changing this to migrate_disable() would do the trick.
Wouldn't we still trip the preempt check even with migration disabled? In another thread I asked the same question: should the preemption checks here be converted to migration-checks in RT? Julia -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html